fix(core-forger): ignore overheight block (#2687)

ArkEcosystem · Jun 12, 2019 · 72dc441 · 72dc441
1 parent 5c9f8cc
commit 72dc441
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/__tests__/unit/core-forger/manager.test.ts b/__tests__/unit/core-forger/manager.test.ts
@@ -80,7 +80,9 @@ describe("Forger Manager", () => {
             setTimeout(() => forgeManager.stopForging(), 1000);
             await forgeManager.checkSlot();
 
-            expect(forgeManager.client.emitEvent).toHaveBeenCalledWith(ApplicationEvents.ForgerFailed, { error: "oh bollocks" });
+            expect(forgeManager.client.emitEvent).toHaveBeenCalledWith(ApplicationEvents.ForgerFailed, {
+                error: "oh bollocks",
+            });
         });
     });
 
@@ -144,7 +146,7 @@ describe("Forger Manager", () => {
             expect(canForge).toBeFalse();
         });
 
-        it("should be FAIL and detect possible double forging", async () => {
+        it("should be TRUE and detect possible double forging", async () => {
             forgeManager.usernames = [];
 
             const networkState = new NetworkState(NetworkStateStatus.Default);
@@ -164,7 +166,7 @@ describe("Forger Manager", () => {
             });
 
             const canForge = await forgeManager.isForgingAllowed(networkState, delegate);
-            expect(canForge).toBeFalse();
+            expect(canForge).toBeTrue();
         });
     });
 });
diff --git a/packages/core-forger/src/manager.ts b/packages/core-forger/src/manager.ts
@@ -212,11 +212,7 @@ export class ForgerManager {
         }> = networkState.getOverHeightBlockHeaders();
         if (overHeightBlockHeaders.length > 0) {
             this.logger.info(
-                `Detected ${overHeightBlockHeaders.length} distinct overheight block ${pluralize(
-                    "header",
-                    overHeightBlockHeaders.length,
-                    true,
-                )}.`,
+                `Detected ${pluralize("distinct overheight block header", overHeightBlockHeaders.length, true)}.`,
             );
 
             for (const overHeightBlockHeader of overHeightBlockHeaders) {
@@ -226,12 +222,8 @@ export class ForgerManager {
                     this.logger.warn(
                         `Possible double forging delegate: ${username} (${delegate.publicKey}) - Block: ${
                             overHeightBlockHeader.id
-                        }. Will not forge.`,
+                        }.`,
                     );
-
-                    this.logger.debug(`Network State: ${networkState.toJson()}`);
-
-                    return false;
                 }
             }
         }