fix(core-blockchain): return if last downloaded block changed (#2216)

ArkEcosystem · Mar 9, 2019 · 37aaa33 · 37aaa33
1 parent 6526856
commit 37aaa33
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/packages/core-blockchain/src/blockchain.ts b/packages/core-blockchain/src/blockchain.ts
@@ -208,6 +208,8 @@ export class Blockchain implements blockchain.IBlockchain {
      * @return {void}
      */
     public clearAndStopQueue() {
+        this.state.lastDownloadedBlock = this.getLastBlock();
+
         this.queue.pause();
         this.queue.clear();
     }

diff --git a/packages/core-blockchain/src/state-machine.ts b/packages/core-blockchain/src/state-machine.ts
@@ -319,6 +319,11 @@ blockchainMachine.actionMap = (blockchain: Blockchain) => ({
             return;
         }
 
+        // Could have changed since entering this function, e.g. due to a rollback.
+        if (lastDownloadedBlock.data.id !== stateStorage.lastDownloadedBlock.data.id) {
+            return;
+        }
+
         const empty = !blocks || blocks.length === 0;
         const chained = !empty && (isBlockChained(lastDownloadedBlock, { data: blocks[0] }) || isException(blocks[0]));