collab :) #1
collab :) #1
Conversation
|
@Arindam200 Hi, feel free to ask question if any doubt on changes! |
|
Or else we can squash the changes :) |
| @@ -396,7 +402,8 @@ async function run(): Promise<void> { | |||
| program.app = Boolean(appRouter) | |||
| } | |||
| } | |||
| if (!process.argv.includes('--turbo') && !process.argv.includes('--no-turbo')) { | |||
|
|
|||
| if (!program.turbo) { | |||
There was a problem hiding this comment.
| if (!program.turbo) { | |
| if (!process.argv.includes('--turbo')) { |
There was a problem hiding this comment.
It's a program.turbo since it uses commandjs, where .option passes value as turbo there
There was a problem hiding this comment.
e.g. --empty to .option passes program.empty value in Commander
There was a problem hiding this comment.
I understand, thank you very much. I suggested it because this was the general usage 👍
There was a problem hiding this comment.
Awesome, thank you for reviewing as well 😌
|
I think we need to add template type |
|
Since we're not adding another template, IMHO we don't need add a template type? Template types seem to targeting for templates. |
I also think so. |
Yes. So, we can merge this PR |
|
Cool, let's ship it!! |
|
Merging this! |
|
I agree with you, maybe we can also offer another pr 🚀 |
…etPrefix (vercel#68694) This PR fixes two issues with the use of `assetPrefix`: #1: vercel#64710 `assetPrefix` needs to be handled in `dev`, `deploy`, and `start`. In the current approach, only `dev` and `start` were handled, but a quirk of the implementation caused rewrites for non-asset paths to not be able to be used in `afterFiles` rewrites. #2: When deploying Next.js (such as on Vercel), you need to add your own `beforeFiles` rewrite for `/${assetPrefix}/_next/...` requests or otherwise they would 404. This PR creates an automatically added `rewrite` to `beforeFiles` that handles the case for `dev`, `start`, and `deploy`, removes the existing logic in `filesystem.ts`, and adds more tests to check the behavior.
No description provided.