-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multitarget for Microsoft.Extensions.ObjectPool #197
Conversation
</ItemGroup> | ||
|
||
<ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | ||
<PackageReference Include="Microsoft.Extensions.ObjectPool" Version="8.0.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it on purpose that you don't use 8.0.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I work in different repos. Some bump dependencies frequently, even patches. Some tend to reference only minimum required for ages. I would not say there is the best strategy for any case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine to use the latest for each major series (8.0.3 for net8) and bump it every time with dependabot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that updating the package with dependabot will ensure our package runs on the newest patches. That's the only argument I can think of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So? 8.0.0 or 8.0.3 ? We can merge with 8.0.0 , publish v7 release and then bump versions for v7.0.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 96.28% 96.90% +0.61%
==========================================
Files 8 8
Lines 485 485
Branches 45 45
==========================================
+ Hits 467 470 +3
+ Misses 9 7 -2
+ Partials 9 8 -1 ☔ View full report in Codecov by Sentry. |
See #193