forked from hashgraph/hedera-smart-contracts
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: transaction checker app (#2) #8
Merged
+2,971
−0
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
16a2e2c
feat: transaction checker app (#2)
mwb-al 414c48c
chore: simplified the `tsconfig.json` by removing all commented-out c…
mwb-al 74c890f
chore: replaced `console.log` with `.error` in to appropriately log e…
mwb-al a155a8b
chore: update logging config and README for consistency and clarity (#2)
mwb-al ae80e71
chore: add TODO for handling payload loss in Mirror Node errors (#2)
mwb-al File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Loading status checks…
chore: add TODO for handling payload loss in Mirror Node errors (#2)
Signed-off-by: Michał Walczak <[email protected]>
commit ae80e7184bf70ac3e21240ad1d1fe91cbd888ff0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make any error repeated if something inside constantly fails, is this desired?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current code does not lead to an infinite loop because the payload is removed from the mirrorQueue using shift() and is not reprocessed in case of an error. However, when the Mirror Node is unavailable and returns an error, we lose such a payload. Addressing this was not part of this task, but I will add a TODO comment to the code - ae80e71