Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-167: Fixes various 404 responses #206

Merged
merged 1 commit into from
Oct 5, 2019
Merged

DEV-167: Fixes various 404 responses #206

merged 1 commit into from
Oct 5, 2019

Conversation

DustinBrett
Copy link
Collaborator

Changes

  • Changed iframe src to use ng-src so it doesn't load the literal {{vm.downloadUrl}} string before Angular has time to replace it
  • Added explicit routes so that loading these URL's doesn't cause a 404 response.

@DustinBrett DustinBrett mentioned this pull request Oct 3, 2019
Closed
@ArekSredzki ArekSredzki merged commit 9ec8ba3 into ArekSredzki:master Oct 5, 2019
@DustinBrett DustinBrett deleted the DEV-167-not-found-fixes branch October 8, 2019 17:01
m0n99 pushed a commit to m0n99/electron-release-server that referenced this pull request Mar 20, 2022
@ArekSredzki
DEV-167: Fixed various 404's (ArekSredzki#206)
7132bd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DustinBrett @ArekSredzki