Paginate available versions and return them in descending semver order #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for this! |
ArekSredzki
approved these changes
Nov 5, 2017
DustinBrett
pushed a commit
to voxter/electron-release-server
that referenced
this pull request
Sep 26, 2019
Fixes bug introduced in PR 166 (ArekSredzki#166). The issue is that `/versions/sorted` (changed at line 537 of `data-service.js`) is not a proper blueprint api call and doesn’t initiate web sockets properly to monitor for updates to the version records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the client-side data service requests a list of available versions, sorts them by their version numbers using semver and then shows them to the user.
The default behaviour of Sails is to return the first 30 database rows, sorted by the primary key in ascending order. This means you'll only get the first 30 versions of your app - if you create a 31st version it will not appear in the release server UI.
This PR:
config/views.js)Happy to make whatever changes are required.