Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python2 support due to https://github.com/ArduPilot/pymavlink/com… #724

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

khancyr
Copy link
Contributor

@khancyr khancyr commented Aug 25, 2022

…mit/046ffa432928010ea051e74aec6f345e7cb9136a

this cause TypeError: 'encoding' is an invalid keyword argument for this function

close #722
Can be seen on ArduPilot environement testing CI : https://github.com/ArduPilot/ardupilot/runs/7927723395?check_suite_focus=true#step:5:4355

this cause   TypeError: 'encoding' is an invalid keyword argument for this function
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tridge tridge merged commit 6c93c44 into ArduPilot:master Aug 25, 2022
@khancyr khancyr deleted the feature/fix-py2-support branch August 25, 2022 22:25
khancyr added a commit to khancyr/pydronecan that referenced this pull request Nov 16, 2022
davidbuzz pushed a commit to dronecan/pydronecan that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip2 upgrade from 2.4.33 to 2.4.34 fails
2 participants