Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavlogdump.py: create local for m.get_type() #681

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

peterbarker
Copy link
Contributor

Before:

pbarker@fx:~/rc/logs$ time mavlogdump.py ./verloop/00000004.BIN -q 

real	0m34.787s
user	0m35.200s
sys	0m1.586s

pbarker@fx:~/rc/logs$ time mavlogdump.py ./verloop/00000004.BIN -q 

real	0m33.335s
user	0m33.683s
sys	0m1.664s
pbarker@fx:~/rc/logs$ 

pbarker@fx:~/rc/logs$ time mavlogdump.py ./verloop/00000004.BIN -q 

real	0m34.979s
user	0m35.332s
sys	0m1.642s
pbarker@fx:~/rc/logs$ 

After:

pbarker@fx:~/rc/logs$ time mavlogdump.py ./verloop/00000004.BIN -q 

real	0m32.996s
user	0m33.331s
sys	0m1.548s
pbarker@fx:~/rc/logs$ time mavlogdump.py ./verloop/00000004.BIN -q 

real	0m32.701s
user	0m33.073s
sys	0m1.639s
pbarker@fx:~/rc/logs$ 

So a few percent faster.

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTL
Pretty sure we already did the same on some other tools of mavproxy in the past, so that is fine

@peterbarker peterbarker merged commit be96722 into ArduPilot:master Aug 11, 2022
@peterbarker peterbarker deleted the pr/get-m-type branch July 3, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants