Restore null pointer detection in parser. #169
Conversation
|
@rolandash Why would you want to invoke |
|
The library uses internal rx buffers by default, so that developers do not need to allocate rx buffers and maintain the pointers to the buffer/status by themselves, actually they have no reason to care about these pointers at all, if they choose to use internal buffers. With the null pointer detections been removed, it either forces developer to use external buffers, or have to get internal buffer pointers first explicitly which are intended to hide from them, and then pass them to the parser which already know these pointers quite well, this seems rather odd in logic, and also deviated from the original design purpose. |
| r_message->len = rxmsg->len; // Provide visibility on how far we are into current msg | ||
| } | ||
| if (NULL != r_mavlink_status) { | ||
| r_mavlink_status->parse_state = status->parse_state; |
There was a problem hiding this comment.
Indent, one whitespace too much
There was a problem hiding this comment.
thanks @amilcarlucas
now the indent should look right.
Removal of null pointer detection in v2.0 suppressed conveniency invocation to parser like:
mavlink_parse_char(MAVLINK_BACKHAUL, *tp, NULL, NULL);Better to restore.