Correct use of TAS/EAS in DCM backend #28728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #25846 |
Co-authored-by: luweiagi <[email protected]>
peterbarker
force-pushed
the
pr/dcm-true-airspeed-bug
branch
from
887c283 to
d877015
Compare
Co-authored-by: luweiagi <[email protected]>
peterbarker
force-pushed
the
pr/dcm-true-airspeed-bug
branch
from
d877015 to
7e97eba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #28727 .
Until that is merged only the top two commits should be looked at in this PR.That PR has been merged.The drift correction code was using EAS when it should be using TAS.
We were returning TAS instead of EAS when no airspeed present.
Ping @luweiagi who dug up these issues in #25846