AP_Param: throw error if we lose parameters #27820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we can't save a parameter due to the queue size not being large enough then there is a coding error, likely the code trying to save large numbers of parameters while armed
andyp1per
reviewed
Aug 13, 2024
| @@ -1266,6 +1266,7 @@ void AP_Param::save(bool force_save) | |||
| if (hal.util->get_soft_armed() && hal.scheduler->in_main_thread()) { | |||
| // if we are armed in main thread then don't sleep, instead we lose the | |||
| // parameter save | |||
| INTERNAL_ERROR(AP_InternalError::error_t::flow_of_control); | |||
There was a problem hiding this comment.
Doesn't this mean we get an internal error while flying? Doesn't seem terribly friendly.
There was a problem hiding this comment.
nearly all our internal errors can happen when flying
peterbarker
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we can't save a parameter due to the queue size not being large enough then there is a coding error, likely the code trying to save large numbers of parameters from main thread while armed