AP_GPS: Backport correct satellite count for SBF DNU NrSv value #27799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amilcarlucas
suggested changes
Aug 9, 2024
libraries/AP_GPS/AP_GPS_SBF.cpp
Outdated
| @@ -453,8 +453,10 @@ AP_GPS_SBF::process_message(void) | |||
| set_alt_amsl_cm(state, ((float)temp.Height - temp.Undulation) * 1e2f); | |||
| } | |||
|
|
|||
| if (temp.NrSV != 255) { | |||
| state.num_sats = temp.NrSV; | |||
| state.num_sats = temp.NrSV; | |||
There was a problem hiding this comment.
The indentation has been corrected, thank you for catching that
chiara-septentrio
force-pushed
the
pr-backport-satellite-count
branch
from
d88bf21
to
c769693
Compare
amilcarlucas
approved these changes
Aug 12, 2024
3 tasks
|
This has been included in Copter-4.5.7-beta1 |
|
We have a report here on the forums that suggests this has negatively impacted the [EKF] failsafe: https://discuss.ardupilot.org/t/coper-4-5-7-beta1-available-for-testing/124355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to Copter 4.5 of PR 26628 : it sets the satellite count to 0 rather than ignoring it