AP_ICEngine: Add CRANK_DIR for direction control of TCA9554 Engine #27076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicrub
previously requested changes
May 16, 2024
loki077
force-pushed
the
pr_hirth_engine_crank_dir
branch
2 times, most recently
from
261307f
to
98c4a3a
Compare
tridge
requested changes
Aug 15, 2024
| #if AP_ICENGINE_TCA9554_STARTER_ENABLED | ||
| // @Group: _TCA9554 | ||
| // @Path: AP_ICEngine_TCA9554.cpp | ||
| AP_SUBGROUPINFO(tca9554_starter, "_TCA", 19, AP_ICEngine, AP_ICEngine_TCA9554), |
There was a problem hiding this comment.
maybe just a ICE_OPTIONS bit instead? That would be a lot smaller patch and not clutter up parameters. We only need a single bit for the direction
There was a problem hiding this comment.
yes that would be good, as if there where other implementation of cranking they can use that flag too for direction control.
There was a problem hiding this comment.
@tridge I have made the changes, have a look.
Also, if there is a need to splitting the commit into one for param mods and other for implementation then let me know.
Added the 5th bit to the ICE_OPTION parameter to enable CRANK_DIR_REVERSE control, specifically for managing Hirth engine direction using AP_ICEngine_TCA9554.
loki077
force-pushed
the
pr_hirth_engine_crank_dir
branch
from
98c4a3a
to
f69806c
Compare
tridge
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter CRAN_DIR where 0 if forward and 1 or greater is reverse direction for Engine Cranking. This is particular with Hirth Engine where both options are available.