Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AP_SerialManager parameters up to AP_Vehicle #26346

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Move AP_SerialManager parameters up to AP_Vehicle #26346

merged 10 commits into from
Feb 29, 2024

Conversation

peterbarker
Copy link
Contributor

No description provided.

@amilcarlucas
Copy link
Contributor 

Binary Name      Text [B]       Data [B]       BSS (B)         Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  -------------  -------------  --------------  ----------------------------  -------------------------
ardurover        88 (+0.0054%)  12 (+0.5119%)  -8 (-0.0031%)   100 (+0.0061%)                                   336544
blimp            84 (+0.0063%)  12 (+0.6276%)  -12 (-0.0046%)  96 (+0.0071%)                                    620660
arducopter       84 (+0.0047%)  12 (+0.3222%)  -12 (-0.0046%)  96 (+0.0054%)                                    192436
arduplane        84 (+0.0048%)  12 (+0.3300%)  -12 (-0.0046%)  96 (+0.0054%)                                    199868
ardusub          88 (+0.0056%)  12 (+0.5119%)  -16 (-0.0062%)  100 (+0.0064%)                                   397780
antennatracker   84 (+0.0064%)  12 (+0.6329%)  -12 (-0.0046%)  96 (+0.0073%)                                    643496
arducopter-heli  84 (+0.0047%)  12 (+0.3222%)  -12 (-0.0046%)  96 (+0.0054%)                                    186124

@peterbarker peterbarker merged commit 0d43f93 into ArduPilot:master Feb 29, 2024
92 checks passed
@peterbarker
Copy link
Contributor Author 

Binary Name      Text [B]       Data [B]       BSS (B)         Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  -------------  -------------  --------------  ----------------------------  -------------------------
ardurover        88 (+0.0054%)  12 (+0.5119%)  -8 (-0.0031%)   100 (+0.0061%)                                   336544
blimp            84 (+0.0063%)  12 (+0.6276%)  -12 (-0.0046%)  96 (+0.0071%)                                    620660
arducopter       84 (+0.0047%)  12 (+0.3222%)  -12 (-0.0046%)  96 (+0.0054%)                                    192436
arduplane        84 (+0.0048%)  12 (+0.3300%)  -12 (-0.0046%)  96 (+0.0054%)                                    199868
ardusub          88 (+0.0056%)  12 (+0.5119%)  -16 (-0.0062%)  100 (+0.0064%)                                   397780
antennatracker   84 (+0.0064%)  12 (+0.6329%)  -12 (-0.0046%)  96 (+0.0073%)                                    643496
arducopter-heli  84 (+0.0047%)  12 (+0.3222%)  -12 (-0.0046%)  96 (+0.0054%)                                    186124

Yeah, 84 bytes for that new conversion function sounds about right.

@peterbarker peterbarker deleted the pr/serialmanager-params-up branch February 29, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

Assignees
No one assigned
Labels
MergeOnCIPass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterbarker @amilcarlucas @tridge