Plane: Manual: use apply_throttle_limits function in manual mode if IDLE_GOV_MANUAL is enabled.
#26283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
force-pushed
the
manual_idle
branch
from
855831d
to
541c5de
Compare
tridge
approved these changes
Feb 26, 2024
|
need CI test that in MANUAL we can go below THR_MIN to allow engine kill |
IamPete1
force-pushed
the
manual_idle
branch
from
541c5de
to
de0d71f
Compare
|
Added a auto test, tested the auto test by hard coding |
tridge
previously requested changes
Feb 28, 2024
peterbarker
reviewed
Feb 28, 2024
| servo_min = self.get_parameter("RC3_MIN") | ||
| servo_max = self.get_parameter("RC3_MAX") |
There was a problem hiding this comment.
There is a get_parameters, but use is not mandatory :-)
IamPete1
force-pushed
the
manual_idle
branch
from
de0d71f
to
f141d39
Compare
IamPete1
dismissed
tridge’s stale review
drain_mav() added to autotest after mode/arming changes.
tridge
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the application of throttle limits to the main
apply_throttle_limitsfunction that all other modes used here:ardupilot/ArduPlane/servos.cpp
Line 507 in e01e697
This makes manual mode behave the same as any other mode. This does result in a couple of changes in behavior:
THR_MAXis also applied along withTHR_MIN.