Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Component Mapping #4641

Closed
dustymc opened this issue May 3, 2022 · 17 comments
Closed

Entity Component Mapping #4641

dustymc opened this issue May 3, 2022 · 17 comments

Comments

@dustymc
Copy link
Contributor

dustymc commented May 3, 2022

This mapping occurs when the entity has no event.

This is true only when the entity is a component of itself, which should probably never be the case (but whatever, I can't and won't try to stop such things, maybe there are good reasons to build self-referencing Entities).

should be no map if no coordinates

Maybe, but I've come around to the idea that a (0,0) point is more informative than a big empty map. If we're going to change that then maybe we need to entirely rethink the prominent map (which I like!).

Originally posted by @dustymc in #3765 (comment)

@dustymc dustymc added this to the Needs Discussion milestone May 3, 2022
@Jegelewicz
Copy link
Member

should be no map if no coordinates

Maybe, but I've come around to the idea that a (0,0) point is more informative than a big empty map. If we're going to change that then maybe we need to entirely rethink the prominent map (which I like!).

We discussed this today in Entity Meeting. Asserting 0,0 coordinates in maps for things without a georeference seems misleading. 0,0 is an actual point on the planet and there could actually be things with that georeference - let's not make up information when none is available.

@Jegelewicz
Copy link
Member

maybe we need to entirely rethink the prominent map (which I like!).

We like it too, but maybe not this much?

image

That is screenshot of an entity page when I first navigate there. Even with coordinates, the giant map is not very informative and doesn't really indicate the important data that can be found below.

We discussed this as well in entity meeting today and here is what we think:

We like the large map - but it is overwhelming. We think the most important entity information are the identification(s) and the other identfier(s). We suggest that we reduce the map a bit so that what you see at the "top" of an entity page is Identifications, Map and Identifiers. Maybe not necessarily in that order, but more like

image

Also, for sections of the entity that hold no asserted information, just don't put them on the page.

image

@ccicero
Copy link

ccicero commented Aug 25, 2022

Revisiting this because @ewommack is looking at entities for some herp tracking data. She looked at Arctos:Entity:10 as an example. The coordinates for one of the two components are encumbered (to protect Golden Eagle nest location). When she is not logged in, she sees this map:

Screen Shot 2022-08-24 at 11 56 25 AM

But here is the correct map when logged in:

image

Mapping localities without coordinates or with encumbered coordinates to 0,0 is confusing and misleading.

This thread is talking about what the map looks like, but first we need to fix how those data are being mapped. We need to fix it so that they don't map if there's no coordinates - not map to 0,0 which is a real place on the globe.

@dustymc
Copy link
Contributor Author

dustymc commented Aug 25, 2022

coordinates for one of the two components are encumbered

https://arctos.database.museum/info/ctDocumentation.cfm?table=ctlocality_attribute_type#locality_access + a public generalized georeference would make this much more accessible (and avoid the mapping thing).

@ccicero
Copy link

ccicero commented Aug 25, 2022

@dustymc What is a 'public generalized georeference' - that doesn't make sense. No (public) coords, no georeference, no mapping. ???

@dustymc
Copy link
Contributor Author

dustymc commented Aug 25, 2022

@ccicero
Copy link

ccicero commented Aug 25, 2022

I'm still unclear. What would the generalized georeference be for the blood sample with encumbered coords in Arctos:Entity:10?

@dustymc
Copy link
Contributor Author

dustymc commented Aug 25, 2022

What would the generalized georeference be

Whatever you're comfortable with. County is generally what the paleo folks generalize to, but ANYTHING is much more useful than nothing, in my view.

(And it's just better way to encumber place data - any human and most machines won't have trouble getting coordinates from your descriptive data, this approach lets you keep that - or whatever you want - private and expose "bay area" or "this county" or whatever is appropriate for the situation.)

@ccicero
Copy link

ccicero commented Aug 25, 2022

County seems reasonable (certainly better than 0,0!), but it seems like it would be useful somehow to distinguish 'real' coordinates from Arctos-created generalized coordinates.

@campmlc
Copy link

campmlc commented Aug 25, 2022 via email

@ewommack
Copy link

@Nicole-Ridgwell-NMMNHS - how do you handle having a public and an encumbered locality for your paleo specimens?

@dustymc
Copy link
Contributor Author

dustymc commented Aug 26, 2022

@ccicero I started from https://arctos.database.museum/guid/MVZ:Bird:193206, cloned the event+locality, edited the original
Screen Shot 2022-08-25 at 4 57 11 PM

edited the event and locality I just made, starting with...

Screen Shot 2022-08-25 at 4 55 57 PM

removed your coordinate encumbrance, and now the record has the precise info (along with the generalized) if you're an Operator, and if you're not....

Screen Shot 2022-08-25 at 5 08 19 PM

general but still useful for lots of things spatial data.

The "real" are clearly distinguished.

Arctos doesn't generate anything (except by demand), this approach allows you to expose exactly whatever you want exposed, however you want to expose it.

Let me know if you want me to un-do that, but I think this is just a better approach than encumbrances for lots of reasons.

@ccicero
Copy link

ccicero commented Aug 26, 2022

That seems ok to me, but I would make a few edits:

'collection assigned by' should not be Doug since that's not correct. I would change that to the person who withheld the locality.

change specific locality to "specific locality withheld' - putting 'no specific locality recorded' also is not correct

verbatim locality - maybe something like 'contact collection staff for details' - ?

Thoughts? Would be good to have a consistent approach to this sort of thing.

image

@dustymc
Copy link
Contributor Author

dustymc commented Aug 26, 2022

"specific locality withheld'

I'm not crazy about purposefully violating our one free-text rule but I don't care if scripts barf on that either so - IDK, maybe we need another "we know but we're not telling" standardization, or maybe that's fine, or ???

Looks like @Nicole-Ridgwell-NMMNHS uses "Specific locality encumbered" (no dot).

Yes standardization is good, IDK how far we can go with that, let me know if I can do something to make it better/easier/whatever.

Otherwise - edit away!

@Nicole-Ridgwell-NMMNHS
Copy link

This may be useful to look at: https://github.com/ArctosDB/Arctos-Workflows/blob/main/.github/ISSUE_TEMPLATE/NMMNH_Single_Locality_Entry.md

In verbatim locality we enter "Locality data more refined than county is encumbered, contact collection for details"

@Nicole-Ridgwell-NMMNHS
Copy link

but it seems like it would be useful somehow to distinguish 'real' coordinates from Arctos-created generalized coordinates.

You can also indicate this in georeference source.

@dustymc dustymc closed this as completed Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants