Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 36 new icons #2226

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Adding 36 new icons #2226

merged 4 commits into from
Aug 1, 2024

Conversation

PurpleBabar
Copy link
Contributor

Hi everybody and thanks for Arcticons it's great 🔥 🎆 😃

I would like to contribute 36 new icons 😄

Let me know if there is something that needs modifying 🤔

Cheerz 👋

Adding 36 new icons
@Donnnno
Copy link
Collaborator

Donnnno commented Jul 31, 2024

Hi! Congrats on your first and also really big contribution! 🎉

I've changed some stuff to make it fit more into Arcticons. Mostly sizing, but also some changes to the lines, to make it more minimal. (I do this with all contributions, it's some sort of quality control)

Here's how they look now:

image

As you can see, I've simplified some lines :)
image
image
image

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 31, 2024

Oh, and I'll make sure that the la poste icon works with the one we already have:
image

Co-Authored-By: PurpleBabar <[email protected]>
@Donnnno
Copy link
Collaborator

Donnnno commented Jul 31, 2024

I can't push my changes. Can you change your repo to give me the permission to push?

@PurpleBabar
Copy link
Contributor Author

Perfect :D thanks a lot, I added you to the repository so you can push :)

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 1, 2024

This works.
But be sure to create a separate branch for your commits, OR change your main branch settings to unprotected. Because this isn't the most ideal workflow. (I had to change my mail settings from private to public :s)

@Donnnno Donnnno merged commit 27965f1 into Arcticons-Team:main Aug 1, 2024
1 check passed
@PurpleBabar
Copy link
Contributor Author

I will definitely create another branch ;) thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants