Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guide. #2197

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Update contribution guide. #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions guides/Contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,26 +23,22 @@
- lines should have a **round cap & round corners**
- the icons should be drawn in **white**
- dots should be a circle with a **radius of 0,5px** (i.e. total size = 1,5 x 1,5 px)
- try to be consistent with sizing your icons, make sure it's not to big or small (use the templates as a reference)
- try to be consistent with sizing your icons, make sure it's not too big or small (use the templates as a reference)
- we don't accept files that are directly image traced, they are a mess to work with and look sloppy
- if you use any letters or numbers make sure to use the font document from the templates folder
- make sure that your SVG file names do not contain any special characters like +-.,!
- upload the SVG files into the `/newicons` directory

### Some features

Before contributing SVG icons, open them inside a text editor and check for the following features. If your icon contains **any** of these SVG features, please replace them before submitting a pull request!
Before contributing SVG icons, open them inside a text editor and check for the following features. If your icon
contains **any** of these SVG features, please replace them before submitting a pull request!

- transform elements
- fill-rule:evenodd
- scientific e-notation

### How to Replace

- **transform elements**: there are several methods to remove this
- delete all transform attributes
- combine one of the transform objects with another one
- un-group the objects
- **fill-rule:evenodd**: these can just be deleted
- **scientific e-notation**: replace them with the normal notation

Expand Down