Contributer image #2190
Merged
Contributer image #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic, I figured that out a while ago, but didn't feel the need to add the internet permission just for such a small thing. Great that you've found a way to add it back! 🎉 |
|
is this ready? :) |
|
No need for a little tweak to start with the build but i can do this later today |
|
Oh, no rush, at all. The new release is at least a few days away (I hope) |
|
Now it is ready |
|
You're the best! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found out what the internet permission was for.
It was used to show the images from Contributors in the About Tab.
I created a solution that downloads the images at build and puts them in the assets Folder.
The original contributor.xml is moved to the generated Folder(dam this needs a better name) this should be the one that gets edited the one in the app/.../xml folder will be generated at build time.
This allows showing the images without having the internet permission.