Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memories icon #2119

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Memories icon #2119

merged 1 commit into from
Jun 9, 2024

Conversation

bonswouar
Copy link
Contributor

@bonswouar bonswouar commented May 10, 2024

Please don't merge this 😄
I'm not a designer at all and I've never used InkScape before, I couldn't get this circle thing right... But if anybody a bit more skilled is motivated to update it, here's my dirty work (:

This is for gallery.memories btw, adapted from their original svg

@bonswouar
Copy link
Contributor Author

bonswouar commented May 10, 2024

Hmm I don't know what I did wrong but compared to some other PRs it seems my image is very small, I've followed the instructions for InkScape though (and I can see it's effectively 48x48 with 1px scale), did I miss something?!

@Kaiserdragon2
Copy link
Collaborator

Hmm I don't know what I did wrong but compared to some other PRs it seems my image is very small, I've followed the instructions for InkScape though (and I can see it's effectively 48x48 with 1px scale), did I miss something?!

Your file is 48x 48 that is correct the only difference is that in your file the heigth and width for render is also defined with 48 if you would save it as plain svg this isn't in there and the image gets rendered bigger on github if compared to the inkscape svg.

But this isn't necessary.

@Kaiserdragon2
Copy link
Collaborator

Please don't merge this 😄 I'm not a designer at all and I've never used InkScape before, I couldn't get this circle thing right... But if anybody a bit more skilled is motivated to update it, here's my dirty work (:

This is for gallery.memories btw, adapted from their original svg

this is not all bad, but some things need change:
there shouldn't be any fill
try drawing around the outlines of the shapes from the original image

we also need the appfilter code you can gather it with https://github.com/Kaiserdragon2/IconRequest

@bonswouar
Copy link
Contributor Author

bonswouar commented May 10, 2024

this is not all bad, but some things need change:
there shouldn't be any fill
try drawing around the outlines of the shapes from the original image

we also need the appfilter code you can gather it with https://github.com/Kaiserdragon2/IconRequest

Got it thanks!

@Donnnno
Copy link
Collaborator

Donnnno commented May 19, 2024

Please take a look at our contribution guide! Your icon doesn't match the style right now, and cannot be merged.
The SVG is also very cluttered

image
image

@dgcampbe
Copy link
Contributor

Here is my attempt:
memories

@dgcampbe
Copy link
Contributor

dgcampbe commented Jun 3, 2024

@Donnnno nudge since this is an older PR :D

@Donnnno
Copy link
Collaborator

Donnnno commented Jun 9, 2024

image
done

@Donnnno Donnnno merged commit ec16aa7 into Arcticons-Team:main Jun 9, 2024
1 check passed
@Donnnno Donnnno mentioned this pull request Jun 9, 2024
Donnnno added a commit that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants