-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memories icon #2119
Memories icon #2119
Conversation
Hmm I don't know what I did wrong but compared to some other PRs it seems my image is very small, I've followed the instructions for InkScape though (and I can see it's effectively 48x48 with 1px scale), did I miss something?! |
Your file is 48x 48 that is correct the only difference is that in your file the heigth and width for render is also defined with 48 if you would save it as plain svg this isn't in there and the image gets rendered bigger on github if compared to the inkscape svg. But this isn't necessary. |
this is not all bad, but some things need change: we also need the appfilter code you can gather it with https://github.com/Kaiserdragon2/IconRequest |
Got it thanks! |
@Donnnno nudge since this is an older PR :D |
Please don't merge this 😄
I'm not a designer at all and I've never used InkScape before, I couldn't get this circle thing right... But if anybody a bit more skilled is motivated to update it, here's my dirty work (:
This is for
gallery.memories
btw, adapted from their original svg