-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added icons bluos, calc_you, ghostery, helium_wallet and one_protect #1903
Conversation
Hello @je223xa , Welcome to Arcticons and congratulations on your first pull request! The icons look good to me at first glance, but Donno, the maintainer of this project, will probably come back to you with more detailed feedback on them. Besides uploading the SVGs, you also need to tell Arcticons what app your icon belongs to. For this, you need to edit the appfilter.xml file in your Fork of Arcticons in the folder "other" > appfilter.xml (or if you can't find it, a direct link to the file in your fork here: The entries are ordered roughly alphabetically. You have to add for each of your icon an entry, that looks something like this:
The word in quotation marks behind "drawable" should be the name of your SVG file. How to find this piece of code, by which an app is internally called? There are several options:
This is just a longer explanation of what is summarized in the Contribution Guide for this project. I myself had some difficulty to understand what is expected from me when I did my first commit to this project some months ago, that's why I wrote it in more detail for you. Please feel free to ask if something is still unclear, and thanks for contributing! |
changed: added second item to Protect entry
Hey there, thank you for providing the detailed information, should've read more carefully I suppose. |
Also if you or anyone reading this is contributing (or planning to) on/from mobile (to whatever degree) make sure to use the raw versions of the files. https://raw.githubusercontent.com/Arcticons-Team/Arcticons/main/other/appfilter.xml Could just be searching if something exists, and if it does fixing it via a quick PR from mobile or doing the Icons on a PC and adding the entries from mobile. |
Co-Authored-By: Jonny Ebinger <[email protected]>
Hey there,
my first contribution ever to anything. But I love this project and think it's worth spending some time on.
Feel free to come back to me with editions or changes, I'd love to contribute more if what I'm doing is good enough for your standards