Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added icons bluos, calc_you, ghostery, helium_wallet and one_protect #1903

Merged
merged 6 commits into from
Jan 13, 2024

Conversation

je223xa
Copy link
Contributor

@je223xa je223xa commented Jan 4, 2024

Hey there,
my first contribution ever to anything. But I love this project and think it's worth spending some time on.
Feel free to come back to me with editions or changes, I'd love to contribute more if what I'm doing is good enough for your standards

@alchemiker
Copy link
Contributor

Hello @je223xa ,

Welcome to Arcticons and congratulations on your first pull request! The icons look good to me at first glance, but Donno, the maintainer of this project, will probably come back to you with more detailed feedback on them.

Besides uploading the SVGs, you also need to tell Arcticons what app your icon belongs to. For this, you need to edit the appfilter.xml file in your Fork of Arcticons in the folder "other" > appfilter.xml (or if you can't find it, a direct link to the file in your fork here:
https://github.com/je223xa/Arcticons/blob/main/other/appfilter.xml

The entries are ordered roughly alphabetically. You have to add for each of your icon an entry, that looks something like this:

<!-- Ghostery -->
<item component="ComponentInfo{com.ghostery.android.ghostery/com.ghostery.android.ghostery.App}" drawable="ghostery"/>

The word in quotation marks behind "drawable" should be the name of your SVG file.

How to find this piece of code, by which an app is internally called? There are several options:

  1. The requests.txt file: at "other" > requests.txt (here) you can search the list of the apps requested by other users with Ctrl + F (this is where I found Ghostery for the example before)
  2. The request function in the Arcticons app: if you have the app you made the icon for installed, you can use the "Icon Request" feature. It opens up an email draft which contains the code for the app you requested.
  3. You can use the app IconRequest which displays this code for all apps which you have on your phone.

This is just a longer explanation of what is summarized in the Contribution Guide for this project. I myself had some difficulty to understand what is expected from me when I did my first commit to this project some months ago, that's why I wrote it in more detail for you.

Please feel free to ask if something is still unclear, and thanks for contributing!

@je223xa
Copy link
Contributor Author

je223xa commented Jan 6, 2024

Hey there, thank you for providing the detailed information, should've read more carefully I suppose.
I have added the entries to appfilter.xml , I have not added an entry for OneProtect since it already had an entry so I've just updated that. Maybe you guys can decide wether to use mine, or the number_1 icon

@TotallyAvailable
Copy link
Contributor

Also if you or anyone reading this is contributing (or planning to) on/from mobile (to whatever degree) make sure to use the raw versions of the files.

https://raw.githubusercontent.com/Arcticons-Team/Arcticons/main/other/appfilter.xml
https://raw.githubusercontent.com/Arcticons-Team/Arcticons/main/other/requests.txt

Could just be searching if something exists, and if it does fixing it via a quick PR from mobile or doing the Icons on a PC and adding the entries from mobile.
Even opening an Issue with what's broken and if you by chance know the correct MainActivity leaving it as a comment is good enough as well. No need to do the whole fork thing just to change a couple letters somewhere in those 29741 lines.

@Donnnno
Copy link
Collaborator

Donnnno commented Jan 13, 2024

Hi! nice work on the icons! I just made some small changes:

  • sizing: some icons were really small, while others were kinda too big.
  • line-width: made sure every line is 1px
  • stroke color: I noticed not all them were #ffffff
Scherm­afbeelding 2024-01-13 om 13 07 45

@Donnnno Donnnno merged commit 9d187d8 into Arcticons-Team:main Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants