Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlook displaying as a Calendar icon #2299

Closed
snaildos opened this issue Sep 28, 2024 · 6 comments
Closed

Outlook displaying as a Calendar icon #2299

snaildos opened this issue Sep 28, 2024 · 6 comments

Comments

@snaildos
Copy link

As the title mentions, the Outlook app is appearing as a calendar.
Screenshot_20240928_120339_One UI Home.jpg

Thanks.

@Richard38907
Copy link

Same here

@gewaleelek
Copy link
Contributor

gewaleelek commented Sep 28, 2024

(Sorry, I thought my previous comment didn't post so I posted another; I've removed the duplicated comment)

My system launcher (realme system launcher) shows the Outlook icon in the home screen and app drawer correctly, but the wrong calendar icon can be observed in some contexts:

  1. When I long-tap the buttons in the bottom menu in the Outlook app, the toast appears and uses the calendar icon instead of the Outlook icon:
toast.mp4
  1. When I share something from the system launcher, the share menu uses the calendar icon for sharing to Outlook instead of the Outlook icon:

An uneducated guess: perhaps my launcher and whatever launchers the other two above me are using are looking for the icon using only the package name (com.microsoft.office.outlook) and not the activity name of the app? Since calendar_31 is listed first in the appfilter.xml file, it gets picked up.

Just putting this here in case the info might help with debugging.

@aloxe
Copy link
Contributor

aloxe commented Sep 28, 2024

This doesn't happen to me.
signal-2024-09-29-001855
I am using Kiss launcher and my Arcticon pack is th 10.4.0

Maybe that could help @gewaleelek and others if you could share what Launcher and Arcticon version you use. Also, when you run the Iconrequest App, does outlook appear as using the calendar icon?

@Richard38907
Copy link

I use a OnePlus device and the calendar icon is displaying: in settings, on the toast popup, on the icon changer dialog but not on the launcher🤔

@Donnnno
Copy link
Collaborator

Donnnno commented Sep 28, 2024

to clear some things up, I added it originally because the activity is called MainCalendarActivity:

<item component="ComponentInfo{com.microsoft.office.outlook/com.microsoft.office.outlook.MainCalendarActivity}" drawable="calendar_31"/>

It seemed like a logical thing to do, because of the name. However, that's not the case in practice, so that means we'll change it in future releases to the normal one, as these:

<!-- Microsoft Outlook -->
<item component="ComponentInfo{com.microsoft.office.outlook/com.microsoft.office.outlook.MainActivity}" drawable="microsoft_outlook"/>
<item component="ComponentInfo{com.microsoft.outlooklite/com.microsoft.outlooklite.MainActivity}" drawable="microsoft_outlook"/>
<item component="ComponentInfo{com.microsoft.outlooklite/com.microsoft.outlooklite.sms.SmsMainActivity}" drawable="microsoft_outlook"/>
<item component="ComponentInfo{com.microsoft.office.outlook/com.microsoft.office.outlook.ui.miit.MiitLauncherActivity}" drawable="microsoft_outlook"/>

Donnnno added a commit that referenced this issue Oct 6, 2024
@Donnnno
Copy link
Collaborator

Donnnno commented Oct 6, 2024

Will be fixed in the next release!

@Donnnno Donnnno closed this as completed Oct 6, 2024
Donnnno added a commit that referenced this issue Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants