Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract links from HTML5 media tags #394

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tsudoko
Copy link

@tsudoko tsudoko commented Oct 10, 2018

Port of mirror/wget@6a2d67b.

I remembered to:

  • Update or add unit tests if needed
  • Update or add documentation/comments if needed
  • Made sure stray files or whitespace didn't get committed
  • If significant changes, branch from develop and set to merge into develop
  • Read the guidelines for contributing

Changes:

  • Adds poster to the list of recognized link attributes and video, audio and source to the list of recognized tags to extract links from.

A few days after making these changes I noticed some of these are actually extracted without being defined there explicitly, not sure if adding them all is a problem. My main reason for making the PR was wpull not downloading files linked in poster attributes.

Port of wget commit 6a2d67b5836a6f1b9c989968a5392ff3511bc1f9.
@JustAnotherArchivist
Copy link
Contributor

Thanks, looks good to me. The test suite is currently failing miserably though for a variety of reasons, and we need to fix that first (see comments on #393).

Copy link
Contributor

@TheTechRobo TheTechRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants