Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for .net client failing to connect in AP 0.4 #54

Merged
merged 5 commits into from
Jul 15, 2022

Conversation

Jarno458
Copy link
Collaborator

@Jarno458 Jarno458 commented Jul 8, 2022

Proposed changes to AP: ArchipelagoMW/Archipelago#757

Games for the PlayerInfo is now based on slot_info rather than games that nolonger holds information per slot
Added list of slot groups to PlayerInfo
Added Unit tests

Ijwu and others added 3 commits July 1, 2022 16:31
Throw TimeoutException if accidentally caught in infinite loop when retrieving from DataStorage.
@Jarno458 Jarno458 requested a review from Ijwu July 8, 2022 11:42
@Jarno458 Jarno458 marked this pull request as draft July 8, 2022 16:34
@Jarno458 Jarno458 marked this pull request as ready for review July 8, 2022 17:56
@Jarno458 Jarno458 changed the base branch from main to V4_development July 8, 2022 18:40
@Jarno458 Jarno458 added the breaking_changes Contains breaking changes, and should therefor likely be part of a major release label Jul 9, 2022
…tibility

# Conflicts:
#	Archipelago.MultiClient.Net.Tests/Archipelago.MultiClient.Net.Tests.csproj
@Ijwu
Copy link
Contributor

Ijwu commented Jul 15, 2022

Thanks, feel free to merge!

@Jarno458 Jarno458 merged commit abe2766 into V4_development Jul 15, 2022
@Jarno458 Jarno458 deleted the fix_player_helper_for_future_compatibility branch July 15, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_changes Contains breaking changes, and should therefor likely be part of a major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants