Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use mousehweel / page scrolling #1

Closed
AngelaIp opened this issue Mar 19, 2019 · 4 comments
Closed

Add option to use mousehweel / page scrolling #1

AngelaIp opened this issue Mar 19, 2019 · 4 comments
Assignees
@cgillis-aras
Labels
Help Wanted Assistance is welcome. Type: Bug Something is not working.

Comments

@AngelaIp
Copy link

Hi,
when I open a Method, it´s right no not possible to scroll down using the mousewheel.
This one seems to be a known issue in the monaco editor. There seem to be a solution available, but haven´t tested yet.
microsoft/monaco-editor#69
@AngelaIp
Copy link
Author

Short update: In my test db page scrolling worked for Chrome, but not for Firefox 60.3.0esr. Maybe a browser related issue.

@EliJDonahue EliJDonahue added Type: Enhancement New feature or improvement. Type: Bug Something is not working. Help Wanted Assistance is welcome. and removed Type: Enhancement New feature or improvement. labels Mar 23, 2019
@cgillis-aras
Copy link
Contributor

Hi @AngelaIp,
I can confirm that scrolling works for me in both Chrome and Edge, and that it does not seem to be working in Firefox. I looked through the editor file, and it appears that the fix you referenced has already been implemented in the version of the Monaco Editor that I'm using in this project.

I'll do some more investigation to see if I can figure out what the issue with Firefox is.

@cgillis-aras
Copy link
Contributor

Looks like there's an issue filed on the Monaco Editor repository about mouse-wheel scrolling not working in Firefox. microsoft/monaco-editor#1353

cgillis-aras added a commit that referenced this issue Mar 26, 2019
@cgillis-aras
Fixing issue where mouse wheel scrolling was not working in Firefox
9d32c57 
This should resolve Issue #1. Firefox uses a different event than other browsers to catch mouse wheel scrolling, so I had to update some core files of the monaco-editor to handle that event appropriately.
@cgillis-aras
Copy link
Contributor

Fixed in 9d32c57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgillis-aras cgillis-aras

Labels
Help Wanted Assistance is welcome. Type: Bug Something is not working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EliJDonahue @cgillis-aras @AngelaIp