Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the FileReaderModule issue #395

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shivaibhavd
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #374

Description

  1. The FileReaderModule was not respecting the data size specified in the frame metadata when creating frames. Instead, it used the file size directly, which caused issues when additional buffer space was required.
  2. Added a read function to use the metadata's size when creating frames. If the metadata's size is larger than the file size, the frame buffer is resized accordingly.
  3. Updated FileReaderModule to handle cases where the metadata's size is not explicitly set. In such cases, the file size is used as the buffer size.

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: (Bug fix)

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

Copy link

Test Results Linux

  1 files  ±0    1 suites  ±0   10m 17s ⏱️ -1s
316 tests +1  229 ✅ +1  83 💤 ±0  4 ❌ ±0 
233 runs  +1  146 ✅ +1  83 💤 ±0  4 ❌ ±0 

For more details on these failures, see this check.

Results for commit 73dd1bd. ± Comparison against base commit d59bf55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant