-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite loading #389
Fix infinite loading #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Hope this will fix the issue 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks even better to me 😆💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! But...
put testing hat
Could you modify the test already in place for the UserRepository so we could check the storage is correctly deleted when the exception is raised please 😄
@MysticFragilist I just changed my phone and I'm hitting this issue, so when this will be available I could test it 😉 |
Oh niiiice! Je vais faire les tests en fin de semaine, ça devrait pas me prendre beaucoup de temps, je ferai une release tout de suite après 😄 |
99382e1
…to fix/android-infinite-loading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question, would it be possible, if the error occurs, to delete the secure storage but instead of asking the user to login again, try to login automatically since we already have the username and password in variables?
@@ -11,7 +11,7 @@ import 'package:notredame/core/managers/user_repository.dart'; | |||
import 'package:ets_api_clients/models.dart'; | |||
|
|||
// OTHERS | |||
import '../../locator.dart'; | |||
import 'package:notredame/locator.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Yes it would be a great idea! I'll create the issue for this :) though I won't wait for this feature to be implemented as the bug is somewhat critical (some user can't even login and is probably the main cause for bad reviews right now 😅) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
Soooo I think I finally manage to find the bug that was making the cache throw an exception on launch (making the app unusable except if we cleared up the cache and storage of the app and starting over). 😄 @apomalyn look at this thread in flutter_secure_storage repo! It's basically the same error that we have when an error occurs on startup. If this PR don't fix it, we will probably need to review the cache manager entirely. I have hopes tho!
What this means
Right now, if a new version comes out and this bug happens on a device, the secure storage will be entirely wiped which means the user will have to login again.
However, it should prevent any new app download from having this issue from now on because of the change in the AndroidManifest.xml.
closes #387