Kind delimiter #844
Merged
Kind delimiter #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lting in a key error
| @@ -226,8 +227,8 @@ def get_kind_key(self, prefix, key_path): | |||
| # are of set size i.e. 2 > 0003 but 0002 < 0003 | |||
| key_id = str(e.id()).zfill(ID_KEY_LENGTH) | |||
| path.append("{0}:{1}".format(e.type(), key_id)) | |||
| encoded_path = '!'.join(path) | |||
| encoded_path += '!' | |||
| encoded_path = '\x01'.join(path) | |||
There was a problem hiding this comment.
Use _KIND_SEPARATOR here, and anywhere else that \x01 is present.
There was a problem hiding this comment.
I'll pull the _KIND_SEPARATOR out to dbconstants, since it spans beyond the one class (hence the reason I didn't use it here, it was out of scope).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.