Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the setNextPageSwipeLock method #903

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

cortinico
Copy link
Member

I'm deprecating the setNextPageSwipeLock method on AppIntroBase.

The method has no effect at all on the ViewPager and is causing confusion on the status of buttons if users happen to call it. We're going to remove the method in the upcoming major version of the library.

Fixes #902

@cortinico cortinico added the bug Issue/PR that is related to a bug in the library/infrastructure label Nov 14, 2020
@cortinico cortinico added this to the 6.1.0 milestone Nov 14, 2020
@cortinico cortinico changed the title dDeprecate the setNextPageSwipeLock method Deprecate the setNextPageSwipeLock method Nov 15, 2020
Copy link
Member

@paolorotolo paolorotolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me.

@paolorotolo paolorotolo merged commit f1d1d02 into master Nov 15, 2020
@paolorotolo paolorotolo deleted the nc/deprecate-setNextPageSwipeLock branch November 15, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that is related to a bug in the library/infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question : how do setButtonsEnabled / setNextPageSwipeLock work ?
2 participants