Fix blending of Indicator Colors #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we blend the user provided colors for the Dot indicator with
appintro_default_unselected_color. That color has a transparency leading to sometimes unexpected behavior.I'm cleaning up the way how we blend colors for indicators. Now the indicator has a white background and is tinted using:
appintro_default_unselected_colorfor unselected indicator, if not specifiedappintro_default_selected_colorfor selected indicator, if not specifiedI've also cleaned up the code a bit as we were using some deprecated functions + we were re-inflating the indicator drawable for every call to
selectPosition. Now is way more streamlined.Fixes #855