Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enabling backward sliding when slide policy not met #817

Merged
merged 2 commits into from
Jun 8, 2020
Merged

enabling backward sliding when slide policy not met #817

merged 2 commits into from
Jun 8, 2020

Conversation

idish
Copy link
Contributor

@idish idish commented Jun 8, 2020

Fix issue #803

Now even though that the slide policy is not met, backward sliding will be permitted.

@cortinico cortinico self-requested a review June 8, 2020 19:42
@cortinico cortinico added the bug Issue/PR that is related to a bug in the library/infrastructure label Jun 8, 2020
@cortinico cortinico added this to the 6.1.0 milestone Jun 8, 2020
@cortinico cortinico merged commit 706441f into AppIntro:master Jun 8, 2020
@cortinico
Copy link
Member

I've added a cleanup for the isASwipeGesture as that check is not needed anymore (the isSwipeForward check is stricter).

Fixes #803

@cortinico
Copy link
Member

Thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
bug Issue/PR that is related to a bug in the library/infrastructure
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@idish @cortinico