Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this PR contains breaking changes.
I've kotlinized all the
Fragments
in the library.Moreover, I cleaned up the exposed Api for
AppIntroFragment
andAppIntro2Fragment
. Now they expose only two methods:newInstance(SliderPage)
as before@JvmOverload
-ed method like thisThis will cover the majority of the use cases. I saw that we had several @deprecated methods, plus other non deprecated
newInstance
methods with a permutation of those parameters.I generally like the two classes now as they're smaller and cleaner. But I'd love to discuss how much aggressive we want to be with removal of old APIs