Some updates #60
Merged
Some updates #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by @TheAssassin in linuxdeploy/linuxdeploy-plugin-gtk#11 (comment), this section should be removed in favor of linuxdeploy-plugin-gtk
TheAssassin
approved these changes
Jan 24, 2021
There was a problem hiding this comment.
LGTM. It makes sense to remove the redundant information in favor of an up-to-date bundling plugin. Any programmer can likely read the code and reproduce the results if needed. This is better than having redundant and outdated information in the docs.
I found just one minor grammar issue.
Co-authored-by: TheAssassin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to remove the "Bundling GTK libraries" section, because it is mainly a part of linuxdeploy-plugin-gtk now.
See linuxdeploy/linuxdeploy-plugin-gtk#11 (comment).