-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create parsec-linux #444
Create parsec-linux #444
Conversation
Looks to me like it ran fine, but firejail may have prevented it from working.
|
What does |
That it couldn't get an internet connection. |
@E5ten can you confirm? If this is the cause, then the application needs to be changed so that it either works without an Internet connection or at the very least give a clear-text GUI error message saying that they cannot work without an Internet connection. Thank you. |
I can confirm, that is what the error means, and it's not an issue with the AppImage but just how parsec works. |
That's a little ridiculous to ask. To obtain this package at all, you need the internet. It's really not the package's fault that you choose to put firejail on every test. This program requires the internet for everything it does. It's used to give games that only have local mutiplayer a way to play online. |
I don't really know about parsec, but I am assuming it is a GUI application? If parsec needs the Internet, but if the Internet is not available, then parsec needs to bring up a GUI dialog box saying "parsec needs the Internet to operate. Apparently you are not connected to the Internet. Please check your connection." or something like that. Otherwise it will just silently fail when launched from the menu which is bad user experience. |
They output an error to the terminal. You're not here to decide the functionality of the AppImage. You're here to test whether it works or not. What you're doing is preventing it from working properly. |
It is a GUI application? |
It is not up to you to decide how they handle errors. |
It is up to you to make sure that you are testing things in a way that the application will work even if it does require the internet. |
Apparently it is a GUI application because on my local machine it comes up like this: So if there is something going wrong, it should show an error and not just silently fail. AppImages are not only invoked from the command line but also from the menu, unless |
Again, it is not up to you to decide how the author of the application handles errors. Your script should be robust enough to tell if an application needs the internet and not prevent it from doing so. There is an error output in the terminal. That is sufficient. |
The fact that the application didn't complain about missing deps is enough for you to know that the test was successful. |
Directly from the parsec website "Error Codes - 18000 (Cannot Contact Parsec Servers)" |
No. The test does much more than that. |
I'm aware, but the rest of the things you check went fine. The only failure here was because of you unnecessarily putting firejail on every test. |
@E5ten please display that as an error message in the GUI, so that someone who invokes the AppImage by double-clicking has a chance to see why it is not launching. Thanks! |
Again, it is not up to you to decide how authors of applications handle errors. |
Why should adding functionality to the base app be the responsibility of the appimage maintainer? |
I am testing how an application behaves when there is no network. This is a requirement for the test to pass... |
Who is that? |
How did you get this application with no network? Having an internet connection is required in order to obtain it in the first place. Running checks without an internet connection for something that requires an internet connection to obtain is just plain silly. |
Many possibilities, e.g., downloaded it before my airplane took off... |
How are you going to play online games on an airplane? |
And why are you trying to use this application that has no functionality outside of online play without internet? |
@E5ten that's not the point. The point is, I don't even know what this application is supposed to do. But I expect from a GUI application that if I launch it from the menu or through a double click, then I can see some action on the screen. Otherwise I am going to assume something is broken. |
It says right on the website what it does. It's used for online gaming. Do you expect to be able to do online gaming without an internet connection? |
Also, this is not at all uncommon on Linux. MANY GUI applications fail to run with NO errors until you run them in a terminal. |
@E5ten pelase export this variable if it is empty. It was also a bug in older versions of electron-builder. Should be solved in the latest electron-builder. electron-userland/electron-builder#682 |
I noticed that in one of my tests also. It doesn't happen on my end with the parsec AppImage when I run it in a terminal... |
What happens in your local tests when you |
Should be fixed. |
No description provided.