-
-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppImage suggestion: Cyph #1837
Comments
Where can the Cyph AppImage be downloaded? The automated test did not find it. |
Oh. Whoops, apparently the repo where I'd published the release was accidentally marked as private. Sorry about that! Just went ahead and fixed that. |
Thanks, this makes a big difference 👍 Is there a reason why the AppImage is not following the default naming scheme, |
I can change it to use the default naming scheme if that would be helpful, but as-is it's being generated with cordova-electron and each output is renamed to cyph.${ext}. |
Yes, this would be very helpful. Thank you. What naming does cordova-electron produce? |
Okay, I just published a new release with the suggested naming scheme. It looks like cordova-electron does |
Thank you, we should open an issue with Cordova then to get them to adopt the recommended naming scheme. Not putting the architecture into the filename is going to lead to confusion, especially as ARM gets more popular. |
Are you using this one? https://github.com/apache/cordova-electron Or do you know in which GitHub repository the code lives that makes an AppImage? |
Yep, the code is either in there or https://github.com/electron-userland/electron-builder (not sure which, but based on electron-userland/electron-builder#1726 it sounds like the latter is at least expected to use the naming convention you suggested). Oddly, the other generated Linux package names are closer to the AppImage convention:
|
Closing. Please open a pull request if you have a link to a Cyph AppImage. |
I'd opened a PR for @cyph (#1762), but didn't get any response.
Also saw a CI failure, so not sure if I did something wrong there.
The text was updated successfully, but these errors were encountered: