Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage suggestion: Cyph #1837

Closed
buu700 opened this issue Nov 27, 2019 · 10 comments
Closed

AppImage suggestion: Cyph #1837

buu700 opened this issue Nov 27, 2019 · 10 comments

Comments

@buu700
Copy link

buu700 commented Nov 27, 2019

I'd opened a PR for @cyph (#1762), but didn't get any response.

Also saw a CI failure, so not sure if I did something wrong there.

@probonopd
Copy link
Member

Where can the Cyph AppImage be downloaded? The automated test did not find it.

@buu700
Copy link
Author

buu700 commented Nov 29, 2019

Oh. Whoops, apparently the repo where I'd published the release was accidentally marked as private. Sorry about that! Just went ahead and fixed that.

@probonopd
Copy link
Member

probonopd commented Nov 29, 2019

Thanks, this makes a big difference 👍

Is there a reason why the AppImage is not following the default naming scheme, cyph-$VERSION-x86_64.AppImage? How did you produce this AppImage?

@buu700
Copy link
Author

buu700 commented Nov 29, 2019

I can change it to use the default naming scheme if that would be helpful, but as-is it's being generated with cordova-electron and each output is renamed to cyph.${ext}.

@probonopd
Copy link
Member

probonopd commented Nov 29, 2019

Yes, this would be very helpful. Thank you.

What naming does cordova-electron produce?

@buu700
Copy link
Author

buu700 commented Nov 30, 2019

Okay, I just published a new release with the suggested naming scheme. It looks like cordova-electron does Cyph $VERSION.AppImage, so I'll just rename it each time I upload it.

@probonopd
Copy link
Member

Thank you, we should open an issue with Cordova then to get them to adopt the recommended naming scheme. Not putting the architecture into the filename is going to lead to confusion, especially as ARM gets more popular.

probonopd added a commit to buu700/appimage.github.io that referenced this issue Nov 30, 2019
@probonopd
Copy link
Member

Are you using this one? https://github.com/apache/cordova-electron

Or do you know in which GitHub repository the code lives that makes an AppImage?

@buu700
Copy link
Author

buu700 commented Nov 30, 2019

Yep, the code is either in there or https://github.com/electron-userland/electron-builder (not sure which, but based on electron-userland/electron-builder#1726 it sounds like the latter is at least expected to use the naming convention you suggested).

Oddly, the other generated Linux package names are closer to the AppImage convention:

  • com.cyph.desktop-1.0.29.x86_64.rpm

  • com.cyph.desktop_1.0.29_amd64.deb

  • com.cyph.desktop_1.0.29_amd64.snap

@probonopd
Copy link
Member

Closing. Please open a pull request if you have a link to a Cyph AppImage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants