Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chaos example issue and enrich notes & diagram #2482

Merged
merged 17 commits into from
Feb 7, 2025

Conversation

caigen
Copy link
Contributor

@caigen caigen commented Feb 7, 2025

Pull Request

The issue or feature being addressed

Resolves #2483.

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature N/A
  • I have successfully run a local build N/A

@caigen

This comment was marked as off-topic.

@caigen

This comment was marked as off-topic.

@caigen caigen mentioned this pull request Feb 7, 2025
@caigen caigen changed the title Fix chaos doc example issue and enrich notes on index.md Fix chaos example issue and enrich notes on index.md Feb 7, 2025
@caigen
Copy link
Contributor Author

caigen commented Feb 7, 2025

@martincostello @martintmk please help to review. :)

docs/chaos/index.md Outdated Show resolved Hide resolved
docs/chaos/index.md Outdated Show resolved Hide resolved
docs/chaos/index.md Outdated Show resolved Hide resolved
docs/chaos/index.md Outdated Show resolved Hide resolved
docs/chaos/index.md Outdated Show resolved Hide resolved
docs/chaos/index.md Outdated Show resolved Hide resolved
docs/chaos/index.md Outdated Show resolved Hide resolved
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

docs/chaos/index.md Show resolved Hide resolved
Make markdownlint happy.
@martincostello
Copy link
Member

Not sure why CI isn't starting - will close and re-open to see if that kicks it.

docs/chaos/index.md Outdated Show resolved Hide resolved
Markdownlint doesn't like sequential notes.
@martincostello martincostello enabled auto-merge (squash) February 7, 2025 09:59
@caigen caigen changed the title Fix chaos example issue and enrich notes on index.md Fix chaos example issue and enrich notes & diagram Feb 7, 2025
docs/chaos/index.md Outdated Show resolved Hide resolved
docs/chaos/index.md Outdated Show resolved Hide resolved
src/Snippets/Docs/Chaos.Index.cs Outdated Show resolved Hide resolved
src/Snippets/Docs/Chaos.Index.cs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (b60cf1d) to head (35dca07).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2482   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         312      312           
  Lines        7466     7466           
  Branches     1121     1121           
=======================================
  Hits         6373     6373           
  Misses        908      908           
  Partials      185      185           
Flag Coverage Δ
linux 85.36% <ø> (ø)
macos 85.36% <ø> (ø)
windows 85.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/chaos/index.md Outdated Show resolved Hide resolved
@martincostello martincostello enabled auto-merge (squash) February 7, 2025 11:31
@martincostello martincostello merged commit aab7385 into App-vNext:main Feb 7, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: chaos document bug
4 participants