Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sliding window ratelimiter examples #2437

Conversation

peter-csala
Copy link
Contributor

Pull Request

The issue or feature being addressed

During this discussion #2425 I've realized that the current sample codes are failing with

System.ArgumentException: SegmentsPerWindow must be set to a value greater than 0. (Parameter 'options')

Details on the issue fix or feature implementation

  • Set the SegmentsPerWindow to 4

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (4f0d44a) to head (13acdfd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2437   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         312      312           
  Lines        7464     7464           
  Branches     1121     1121           
=======================================
  Hits         6374     6374           
  Misses        905      905           
  Partials      185      185           
Flag Coverage Δ
linux 85.39% <ø> (+0.02%) ⬆️
macos 85.39% <ø> (ø)
windows 85.36% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-csala peter-csala force-pushed the Fix-sliding-window-rate-limiter-examples branch from 638fd73 to 13acdfd Compare January 10, 2025 11:46
@martincostello martincostello merged commit ca22978 into App-vNext:main Jan 10, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants