Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Extensions.Caching.Memory #2347

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Oct 16, 2024

Pull Request

The issue or feature being addressed

https://github.com/App-vNext/Polly/actions/runs/11350676295/job/31569591613?pr=2346

Build FAILED.

D:\a\Polly\Polly\bench\Polly.Benchmarks\Polly.Benchmarks.csproj : error NU1903: Package 'Microsoft.Extensions.Caching.Memory' 8.0.0 has a known high severity vulnerability, GHSA-qj66-m88j-hmgj [TargetFramework=net6.0]

Details on the issue fix or feature implementation

  • Bumped Microsoft.Extensions.Caching.Memory's package version from 8.0.0 to 8.0.1
  • Couldn't bump all extensions because not all has 8.0.1 (for exampleMicrosoft.Extensions.Http.Resilience)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (cf14f4b) to head (a3e147d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2347      +/-   ##
==========================================
+ Coverage   85.37%   85.40%   +0.02%     
==========================================
  Files         313      313              
  Lines        7467     7467              
  Branches     1125     1125              
==========================================
+ Hits         6375     6377       +2     
+ Misses        746      745       -1     
+ Partials      346      345       -1     
Flag Coverage Δ
linux 85.40% <ø> (+0.02%) ⬆️
macos 85.37% <ø> (?)
windows 85.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 14ac109 into App-vNext:main Oct 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants