Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate mutation tests #2331

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

ShawnWu33
Copy link
Contributor

@ShawnWu33 ShawnWu33 commented Oct 7, 2024

Pull Request

The issue or feature being addressed

Resolves #1755

Details on the issue fix or feature implementation

  • Create two new workflow to cover mutation test core and mutation test legacy.
  • Modify cake scirpt to accomodate another two target "MutationCore" and "MutationLegacy"
  • Remove mutation test in build workflow

Tested these three workflow in my repo, below is what they lookslike during execution:
Build workflow: https://github.com/ShawnWu33/Polly/actions/runs/11216605547
Mutation core workflow: https://github.com/ShawnWu33/Polly/actions/runs/11216605554
Mutation legacy workflow: https://github.com/ShawnWu33/Polly/actions/runs/11216605545

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (4e7d099) to head (4cf290e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2331   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         313      313           
  Lines        7467     7467           
  Branches     1126     1126           
=======================================
  Hits         6377     6377           
  Misses        745      745           
  Partials      345      345           
Flag Coverage Δ
linux 85.37% <ø> (-0.03%) ⬇️
macos 85.40% <ø> (+0.02%) ⬆️
windows 85.40% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShawnWu33 ShawnWu33 force-pushed the seperate_mutation_tests branch 2 times, most recently from ed70307 to 07aa44d Compare October 9, 2024 01:33
@ShawnWu33 ShawnWu33 force-pushed the seperate_mutation_tests branch from 07aa44d to 260bc68 Compare October 9, 2024 01:49
.github/workflows/mutation-tests.yml Outdated Show resolved Hide resolved
.github/workflows/mutation-tests.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/mutation-tests.yml Outdated Show resolved Hide resolved
.github/workflows/mutation-tests.yml Outdated Show resolved Hide resolved
.github/workflows/mutation-tests.yml Outdated Show resolved Hide resolved
.github/workflows/mutation-tests.yml Outdated Show resolved Hide resolved
.github/workflows/mutation-tests.yml Outdated Show resolved Hide resolved
build.cake Outdated Show resolved Hide resolved
.github/workflows/mutation-tests.yml Outdated Show resolved Hide resolved
@martincostello
Copy link
Member

Just one final edit please, then this should be good to go. I'll just need to get the required statuses updated.

@martincostello
Copy link
Member

@joelhulen Could you edit the branch protections to make the following required please?

  • mutations-core
  • mutations-legacy
  • lint
  • dependency-review
  • docs
  • validate-packages

@martincostello martincostello merged commit be68ba3 into App-vNext:main Oct 10, 2024
20 checks passed
@martincostello
Copy link
Member

Thanks again for this @ShawnWu33 - this shaves a good 10-15 minutes off the total time between opening a PR and being able to merge it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Speed-up the build by executing the mutation tests in a separate workflow
2 participants