Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signing workflow #2323

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update signing workflow #2323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bddef6
Update AuthenticodeLint
martincostello Oct 1, 2024
23e17ac
Set env vars for sign
martincostello Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,10 @@ jobs:

- name: Sign artifacts
shell: pwsh
env:
AZURE_CLIENT_ID: ${{ secrets.SIGN_CLI_APPLICATION_ID }}
AZURE_CLIENT_SECRET: ${{ secrets.SIGN_CLI_SECRET }}
AZURE_TENANT_ID: ${{ secrets.SIGN_CLI_TENANT_ID }}
run: |
./sign code azure-key-vault `
**/*.nupkg `
Expand All @@ -203,9 +207,9 @@ jobs:
--description "Polly" `
--description-url "https://github.com/${{ github.repository }}" `
--azure-key-vault-certificate "${{ secrets.SIGN_CLI_CERT_NAME }}" `
--azure-key-vault-client-id "${{ secrets.SIGN_CLI_APPLICATION_ID }}" `
--azure-key-vault-client-secret "${{ secrets.SIGN_CLI_SECRET }}" `
--azure-key-vault-tenant-id "${{ secrets.SIGN_CLI_TENANT_ID }}" `
--azure-key-vault-client-id ${env:AZURE_CLIENT_ID} `
--azure-key-vault-client-secret ${env:AZURE_CLIENT_SECRET} `
--azure-key-vault-tenant-id ${env:AZURE_TENANT_ID} `
--azure-key-vault-url "${{ secrets.SIGN_CLI_VAULT_URI }}" `
--verbosity "${{ runner.debug == '1' && 'Debug' || 'Warning' }}"
if ($LASTEXITCODE -ne 0) {
Expand Down Expand Up @@ -258,7 +262,7 @@ jobs:
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
path: AuthenticodeLint
ref: ae44826fdcebaa671b06591ea0b3b47fc946b79c
ref: 90dd05293effe918b149c7f8323540b7730c06d2
repository: martincostello/AuthenticodeLint
submodules: recursive

Expand Down