Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the Polly.Utils.ObjectPool class #2312

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

gabidabet
Copy link
Contributor

Pull Request

The issue or feature being addressed

Maintainability and code quality.

Details on the issue fix or feature implementation

Remove code redundancy of constructors of class ObjectPool.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (67f0b17) to head (8a54b36).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2312      +/-   ##
==========================================
- Coverage   85.39%   85.38%   -0.01%     
==========================================
  Files         313      313              
  Lines        7461     7457       -4     
  Branches     1126     1126              
==========================================
- Hits         6371     6367       -4     
  Misses        745      745              
  Partials      345      345              
Flag Coverage Δ
linux 85.38% <100.00%> (-0.01%) ⬇️
macos 85.35% <100.00%> (?)
windows 85.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (squash) September 26, 2024 19:34
@martincostello martincostello merged commit 22d09c0 into App-vNext:main Sep 26, 2024
15 checks passed
@gabidabet gabidabet deleted the clean-object-pool-class branch September 26, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants