Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning CA1062#DefaultCacheKeyStrategy #2218

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Jul 21, 2024

Pull Request

The issue or feature being addressed

#2215

Details on the issue fix or feature implementation

  • Suppress CA1062 in src/Polly/Caching/DefaultCacheKeyStrategy.cs or fix the warning

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.93%. Comparing base (c75b43b) to head (4fa02d4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2218      +/-   ##
==========================================
+ Coverage   83.90%   83.93%   +0.03%     
==========================================
  Files         313      313              
  Lines        7181     7183       +2     
  Branches     1061     1062       +1     
==========================================
+ Hits         6025     6029       +4     
+ Misses        785      784       -1     
+ Partials      371      370       -1     
Flag Coverage Δ
linux 83.90% <100.00%> (+<0.01%) ⬆️
macos 83.93% <100.00%> (+0.03%) ⬆️
windows 83.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.4.2 milestone Jul 21, 2024
@martincostello martincostello merged commit 994193e into App-vNext:main Jul 21, 2024
18 checks passed
@Zombach Zombach deleted the zombach/remove-warning-ca1062#default-cache-key-strategy branch July 21, 2024 16:08
@martincostello martincostello removed this from the v8.4.2 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants