Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix chaos outcome exception handling #2101

Merged
merged 8 commits into from
May 10, 2024
Merged

[Bug] Fix chaos outcome exception handling #2101

merged 8 commits into from
May 10, 2024

Conversation

peter-csala
Copy link
Contributor

Pull Request

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

martincostello
martincostello approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, just one style suggestion.

src/Polly.Core/Simmy/Outcomes/ChaosOutcomeStrategy.cs Outdated Show resolved Hide resolved
@martincostello martincostello requested a review from martintmk May 9, 2024 17:38
@martintmk martintmk merged commit 41d27ff into App-vNext:main May 10, 2024
16 checks passed
@martincostello martincostello added this to the v8.4.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

@martintmk martintmk martintmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@peter-csala @martincostello @martintmk