-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix potential github action smells #2097
Conversation
- Use 'if' for upload-artifact action - Avoid uploading artifacts on forks - Prevent running issue/PR actions on forks - Avoid deploying jobs on forks
@martincostello is it really neccessary to run |
I didn't specifically disable it because my understanding was that GitHub automatically disables actions for new forks. This was something I used to do in all my own repos, but I've stopped because I thought the default didn't need it anymore. See https://github.com/orgs/community/discussions/26704#discussioncomment-3252979 If that isn't the case we can look to turn it off explicitly, but if we do so I would want to code to do it the way I suggested in my review, not with hard-coding the repository name: #2097 (comment) |
Co-authored-by: Martin Costello <[email protected]>
Restore whitespace.
Disable three additional workflows on forks.
Thanks for your contribution @ceddy4395 - the changes from this pull request have been published as part of version 8.4.1 📦, which is now available from NuGet.org 🚀 |
Pull Request
Hey! 🙂
I want to contribute the following changes to your workflow:
(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)
The issue or feature being addressed
Details on the issue fix or feature implementation
Confirm the following