Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PipelineNameComparer example in documentation #1931

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fix PipelineNameComparer example in documentation #1931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6470af3
Fix PipelineNameComparer example in documentation
jwagon Jan 26, 2024
e0333c3
Fix PipelineNameComparer example in documentation snippet
jwagon Jan 26, 2024
583c3f1
Fix string comparison warning
jwagon Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/advanced/dependency-injection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ public sealed class PipelineNameComparer : IEqualityComparer<MyPipelineKey>
{
public bool Equals(MyPipelineKey x, MyPipelineKey y) => x.PipelineName == y.PipelineName;

public int GetHashCode(MyPipelineKey obj) => (obj.PipelineName, obj.InstanceName).GetHashCode();
public int GetHashCode(MyPipelineKey obj) => obj.PipelineName.GetHashCode();
}
```
<!-- endSnippet -->
Expand Down
2 changes: 1 addition & 1 deletion src/Snippets/Docs/DependencyInjection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ public sealed class PipelineNameComparer : IEqualityComparer<MyPipelineKey>
{
public bool Equals(MyPipelineKey x, MyPipelineKey y) => x.PipelineName == y.PipelineName;

public int GetHashCode(MyPipelineKey obj) => (obj.PipelineName, obj.InstanceName).GetHashCode();
public int GetHashCode(MyPipelineKey obj) => obj.PipelineName.GetHashCode(StringComparison.Ordinal);
}

#endregion
Expand Down
Loading