Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BreakDurationGeneratorArguments now includes half-open attempts #1898

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 13, 2024

Pull Request

The issue or feature being addressed

Closes #1895

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added this to the v8.3.0 milestone Jan 13, 2024
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e91a18) 84.66% compared to head (c33b299) 84.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
+ Coverage   84.66%   84.68%   +0.02%     
==========================================
  Files         309      309              
  Lines        6836     6845       +9     
  Branches     1052     1052              
==========================================
+ Hits         5788     5797       +9     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.68% <100.00%> (+0.02%) ⬆️
macos 84.68% <100.00%> (+0.02%) ⬆️
windows 84.68% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk merged commit fd1b310 into main Jan 13, 2024
17 checks passed
@martintmk martintmk deleted the mtomka/circuit-breaker-attempts branch January 13, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants