-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simmy docs #1883
Simmy docs #1883
Conversation
# Conflicts: # src/Polly.Core/PublicAPI.Unshipped.txt
You just have to run these two commands and you can test the documentation website locally: Download the
|
@vany0114 Could you please update the PR description in a way that you highlight what is already done and what's still missing? Then we can split the remaining work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some words need adding to the spellcheck dictionary and the C# snippets need to be added as code.
@vany0114 Please allow me (@peter-csala) to contribute to your branch (otherwise I have to create a fork from your branch). |
@peter-csala done |
Added some comments, otherwise it looks really great @vany0114 and @peter-csala! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
=======================================
Coverage 84.65% 84.65%
=======================================
Files 309 309
Lines 6828 6828
Branches 1050 1050
=======================================
Hits 5780 5780
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@vany0114 When I was reading the |
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits, otherwise LGTM
Let's get rid of extra logos and . Wdyt, @martincostello anything else is missing? |
I have three unresolved comments, but otherwise I'm happy if you and @vany0114 are happy. |
Co-authored-by: martintmk <[email protected]>
@martincostello , @martintmk For me it seems a bit odd to have |
Let's put it just before the advanced section. |
Is there anything that needs to be addressed or can we ? |
I think it fine to merge. @martincostello ? |
Just waiting on some feedback from @vany0114. |
@peter-csala thanks a lot for the help! it looks good to me. |
Simmy docs.
Didn't run the docs website locally bc I don't know how, if you guys think I should please let me know how.