Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test package signing #1762

Closed
wants to merge 20 commits into from
Closed

Test package signing #1762

wants to merge 20 commits into from

Conversation

martincostello
Copy link
Member

Branch for testing changes in #1761.

Bump sign to 0.9.1-beta.23530.1.
Test that #1761 resolves the issue.
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e404873) 84.53% compared to head (b6137eb) 84.53%.
Report is 1 commits behind head on main.

❗ Current head b6137eb differs from pull request most recent head e6f547b. Consider uploading reports for the commit e6f547b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1762   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files         307      307           
  Lines        6777     6777           
  Branches     1043     1043           
=======================================
  Hits         5729     5729           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos ?
windows 84.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Use .NET 6.0.416 SDK for all signing steps.
Disable tests to speed up feedback loop.
Add support for debugging the `sign` tool.
Downgrade to see if some change to NuGet broke something.
Use fork of AuthenticodeLint with hopeful fix to validation issue.
Speed things up.
Suppress two warnings when building from source.
Pin the version of the .NET 6 SDK used to build AuthenticodeLint.
- Setup .NET to install the tools.
- Clone submodules.
Back to 7.0.403.
As build is being skipped.
Suppress warnings in the tool as well as NU1902.
Needed for deterministic builds.
Test not-hard-coded versions of the SDK.
Fix checking out the code deleting the downloaded artifacts.
Checkout to a sub-directory and point to the global.json in it.
Instead of cloning Polly multiple times, use the SDK output from setup-dotnet.
Use `github.repository` to get the repository name instead of hard-coding it.
@martincostello
Copy link
Member Author

Things appear to be sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant