Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #1630

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Documentation updates #1630

merged 9 commits into from
Sep 27, 2023

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Sep 26, 2023

Apply some grammar and wording changes to the documentation for v8.

I'm slowly making my way through the PRs from while I was on holiday and making edits that I would have suggested via PR review. Once I've caught up and move this out of draft for review.

Apply some grammar and wording changes to the documentation for v8.
@martincostello martincostello added documentation v8 Issues related to the new version 8 of the Polly library. labels Sep 26, 2023
@martincostello martincostello added this to the v8.0.0 milestone Sep 26, 2023
Update grammar/wording for MaxDelay.
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (53805c5) 84.63% compared to head (a552f86) 84.63%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1630   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6819     6819           
  Branches     1045     1045           
=======================================
  Hits         5771     5771           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos ?
windows 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/Polly.Core/Retry/RetryStrategyOptions.TResult.cs 100.00% <ø> (ø)
...dencyInjection/PollyServiceCollectionExtensions.cs 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix some grammar and spelling.
Tweak some wording and snippets.
Apply some grammar changes.
- Tweak some grammar.
- Add links to concepts.
Update some grammar and links.
Apply some further refinements and links  to the docs.
@martincostello martincostello marked this pull request as ready for review September 26, 2023 14:26
docs/migration-v8.md Outdated Show resolved Hide resolved
Copy link
Contributor

@martintmk martintmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of that capitalization thing it looks good! Great job :)

Revert usage of title case in headings.
@martincostello martincostello enabled auto-merge (squash) September 27, 2023 09:14
@martincostello martincostello merged commit b0ffc12 into main Sep 27, 2023
14 checks passed
@martincostello martincostello deleted the docs-tweaks branch September 27, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants